This repository was archived by the owner on Sep 11, 2025. It is now read-only.
enh: automatically determine coverage data #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 146744638
💛 - Coveralls |
mmarkelov
reviewed
Jun 23, 2020
…into enhancement/coverage
mxschmitt
commented
Jun 24, 2020
| ), | ||
| ) | ||
| // wait until coverage data was sent successfully to the exposed function | ||
| await new Promise((resolve) => setTimeout(resolve, 10)) |
Collaborator
Author
There was a problem hiding this comment.
I found no other way of doing that. By using a sleep of 10ms it should be enough to let the event loop handle to execute the beforeunload handling and its corresponding disk write.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
saveCoveragefunction.