Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mxschmitt
Copy link
Collaborator

@mxschmitt mxschmitt commented Jun 20, 2020

TODOs:

Example usage here: playwright-community/playwright-jest-examples#8

Will look like that if you are using the example:
image

@mxschmitt mxschmitt requested a review from mmarkelov as a code owner June 20, 2020 13:52
@github-actions
Copy link

Pull Request Test Coverage Report for Build 141857263

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.238%

Totals Coverage Status
Change from base Build 141220261: 0.0%
Covered Lines: 71
Relevant Lines: 72

💛 - Coveralls

@mmarkelov
Copy link
Member

@mxschmitt that's a really nice new feature. But maybe we should put it in separate package and make it optional?

@mxschmitt
Copy link
Collaborator Author

@mxschmitt that's a really nice new feature. But maybe we should put it in separate package and make it optional?

Unfortunately it needs a tight integrations in before all tests and after all tests hooks. That's why I think it does not make so much sense and would decrease the user experience for that significantly. As a pitfall it adds a few more dependencies, but shouldn't be a big deal in my mind.

@mxschmitt
Copy link
Collaborator Author

Let me know if they are any other issues before we can merge it. Thanks! 👍

@mmarkelov
Copy link
Member

Let me know if they are any other issues before we can merge it. Thanks! 👍

I think we are ready to merge it

@mxschmitt mxschmitt merged commit eb894fe into master Jun 22, 2020
@mxschmitt mxschmitt deleted the feature/coverage branch June 22, 2020 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants