This repository was archived by the owner on Sep 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
feat: collect coverage of end-to-end tests #147
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 141857263
💛 - Coveralls |
Member
|
@mxschmitt that's a really nice new feature. But maybe we should put it in separate package and make it optional? |
Collaborator
Author
Unfortunately it needs a tight integrations in before all tests and after all tests hooks. That's why I think it does not make so much sense and would decrease the user experience for that significantly. As a pitfall it adds a few more dependencies, but shouldn't be a big deal in my mind. |
mmarkelov
reviewed
Jun 21, 2020
mmarkelov
reviewed
Jun 21, 2020
Collaborator
Author
|
Let me know if they are any other issues before we can merge it. Thanks! 👍 |
Member
I think we are ready to merge it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
saveCoveragedoesPlaywrightRunner.runTestsis okayExample usage here: playwright-community/playwright-jest-examples#8
Will look like that if you are using the example:
