fix: checkDependencies if no package was found

[mxschmitt]

In the previous release there was a bug, that caused checkDependenices() to return an empty object if no playwright package was found. This resulted to a truthy if condition here:

jest-playwright/src/utils.ts

Lines 78 to 95 in 6e0d933

	export const readPackage = async (): Promise<
	Packages | typeof IMPORT_KIND_PLAYWRIGHT
	> => {
	const packagePath = 'package.json'
	const absConfigPath = path.resolve(process.cwd(), packagePath)
	const packageConfig = await require(absConfigPath)
	// for handling the local tests
	if (packageConfig.name === 'jest-playwright-preset') {
	return IMPORT_KIND_PLAYWRIGHT
	}
	const playwright =
	checkDependencies(packageConfig.dependencies) ||
	checkDependencies(packageConfig.devDependencies)
	if (!playwright || !Object.keys(playwright).length) {
	throw new Error('None of playwright packages was not found in dependencies')
	}
	return playwright
	}

Which cause the following error:

None of playwright packages was not found in dependencies

[coveralls]

Pull Request Test Coverage Report for Build 135785839

• 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.2%) to 95.238%

---

Totals
Change from base Build 135653308:	0.2%
Covered Lines:	71
Relevant Lines:	72

---

💛 - Coveralls

[mxschmitt]

I think we should check on the packages variable instead of the dependencies variable. Since in my case, both are filled but only devDependencies does contain the playwright related packages.

[mmarkelov]

@mxschmitt yeah! That's true, but it will cover case when dependencies or devDependencies are defined, but empty. It should return null, and then we can check if they have some of playwright dependencies. So we check length of packages variable in the end. And in readPackage we can check result with null

[mxschmitt]

LGTM now 👍