Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Conversation

@mxschmitt
Copy link
Collaborator

@mxschmitt mxschmitt commented May 26, 2020

Very very early integration. Probably I can implement it without touching the environment at all.

The closing of the browser instances needs to be implemented somehow. Will continue soon.

Fixes #133

@mxschmitt mxschmitt force-pushed the feature/reuse-browser branch from c773b90 to c7ea566 Compare June 15, 2020 10:13
@github-actions
Copy link

Pull Request Test Coverage Report for Build 135837208

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.238%

Totals Coverage Status
Change from base Build 135799437: 0.0%
Covered Lines: 71
Relevant Lines: 72

💛 - Coveralls

@mxschmitt mxschmitt marked this pull request as ready for review June 15, 2020 10:15
@mxschmitt mxschmitt requested a review from mmarkelov as a code owner June 15, 2020 10:15
@mxschmitt
Copy link
Collaborator Author

Probably some refactoring is needed, but something like this would work in my mind.

@mxschmitt
Copy link
Collaborator Author

mxschmitt commented Jun 16, 2020

I'll try to adjust it, so that there is no change in the environment required. should also be possible.
cc @mmarkelov

@mxschmitt mxschmitt self-assigned this Jun 17, 2020
@mxschmitt
Copy link
Collaborator Author

I'll try to adjust it, so that there is no change in the environment required. should also be possible.
cc @mmarkelov

Probably not possible since we only get the wsEndpoint from the config. Now we also get it from the config by passing it from the runner over to the environment. I think we can merge this and your changes to make a beta release.

@mmarkelov mmarkelov merged commit 8679770 into master Jun 18, 2020
@mmarkelov mmarkelov deleted the feature/reuse-browser branch June 18, 2020 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share browser instance for multiple test files

3 participants