This repository was archived by the owner on Sep 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
feat: reuse browser with the jest-runner #134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
May 26, 2020
…into feature/reuse-browser
c773b90 to
c7ea566
Compare
Pull Request Test Coverage Report for Build 135837208
💛 - Coveralls |
Collaborator
Author
|
Probably some refactoring is needed, but something like this would work in my mind. |
…into feature/reuse-browser
Collaborator
Author
|
I'll try to adjust it, so that there is no change in the environment required. should also be possible. |
mmarkelov
approved these changes
Jun 16, 2020
Collaborator
Author
Probably not possible since we only get the wsEndpoint from the config. Now we also get it from the config by passing it from the runner over to the environment. I think we can merge this and your changes to make a beta release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very very early integration. Probably I can implement it without touching the environment at all.
The closing of the browser instances needs to be implemented somehow. Will continue soon.
Fixes #133