Attempting to use -firefox with -chromium installed results in TypeError

[narthollis]

I have just starting playing with jest + playwright and was trying to run multiple browser configurations when I ran into this issue.

The error I am getting is

 FAIL   browser: firefox  tests/basic.test.ts
  ● Test suite failed to run

    TypeError: Cannot read property 'launch' of undefined

      at getBrowserPerProcess (node_modules/jest-playwright-preset/lib/PlaywrightEnvironment.js:24:41)
      at PlaywrightEnvironment.setup (node_modules/jest-playwright-preset/lib/PlaywrightEnvironment.js:62:41)

 FAIL   browser: firefox  tests/basic.test.js
  ● Test suite failed to run

    TypeError: Cannot read property 'launch' of undefined

      at getBrowserPerProcess (node_modules/jest-playwright-preset/lib/PlaywrightEnvironment.js:24:41)
      at PlaywrightEnvironment.setup (node_modules/jest-playwright-preset/lib/PlaywrightEnvironment.js:62:41)

Test Suites: 2 failed, 2 total
Tests:       0 total
Snapshots:   0 total
Time:        0.339 s
Ran all test suites.

jest.config.js

module.exports = {
  preset: 'jest-playwright-preset'
};

jest-playwright.config.js

module.exports = {
  browsers: [
    //  "chromium",
      "firefox"
    ]
};

basic.test.js

describe('basic test', () => {
    it('should load google.com', async () => {
        await page.goto('https://google.com/');
        expect(await page.title()).toBe("Google");
    });

    it('should also load google.com', async () => {
        await page.goto('https://google.com/');
        expect(await page.title()).toBe("Google");
    })
});

[narthollis]

Having a read of the source I believe that the issue is that the checkDependencies function is always returning the playwright-chromium package if it is installed.

jest-playwright/src/utils.ts

Lines 20 to 29 in 00e15e5

	export const checkDependencies = (
	dependencies: Record<string, string>,
	): PlaywrightRequireType | null => {
	if (!dependencies) return null
	if (dependencies.playwright) return IMPORT_KIND_PLAYWRIGHT
	if (dependencies[`playwright-${CHROMIUM}`]) return CHROMIUM
	if (dependencies[`playwright-${FIREFOX}`]) return FIREFOX
	if (dependencies[`playwright-${WEBKIT}`]) return WEBKIT
	return null
	}

which is causing readPackage to also always return playwright-chromium

jest-playwright/src/utils.ts

Line 73 in 00e15e5

export const readPackage = async (): Promise<PlaywrightRequireType> => {

and this flows through to getPlaywrightInstance to attempt to find a firefox property on the playwright-chromium export.

jest-playwright/src/utils.ts

Lines 90 to 93 in 00e15e5

	export const getPlaywrightInstance = (
	playwrightPackage: PlaywrightRequireType,
	browserName: BrowserType,
	): Playwright => {

[mmarkelov]

@narthollis seems like a bug. As I understood you got separated playwright packages.

// package.json
"devDependencies": {
    "playwright-chromium": ">=0.12.1",
    "playwright-firefox": ">=0.12.1",
    "playwright-webkit": ">=0.12.1",
  }

And you try to running tests for firefox?

[narthollis]

Yeah, this is correct.

…

On Wed, 10 Jun 2020, 18:47 Maksim Markelov, ***@***.***> wrote: @narthollis <https://github.com/narthollis> seems like a bug. As I understood you got separated playwright packages. // package.json"devDependencies": { "playwright-chromium": ">=0.12.1", "playwright-firefox": ">=0.12.1", "playwright-webkit": ">=0.12.1", } And you try to running tests for firefox? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#139 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAQRFAKGCRW7CEGGPSTYHTRV5FRHANCNFSM4NZKGKRA> .

[narthollis]

@mmarkelov Any ideas when this might be released?

[mmarkelov]

@narthollis sorry for late response. I just published 0.2.4, that should fix your issue. Thanks!

[narthollis]

Thats working! Thanks very much.