Skip to content

Add new "no element handle" rule #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 11, 2022
Merged

Add new "no element handle" rule #40

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
83ca91d
rule: add new noElementHandle rule
elaichenkov Apr 10, 2022
09acdee
chore: move end range to const
elaichenkov Apr 10, 2022
bf274cc
fix: getRange method for non-awaiting statements
elaichenkov Apr 10, 2022
6ba89e1
test: add additional tests for the noElementHandle rule
elaichenkov Apr 10, 2022
e151e3c
chore: improve noElementHandle rule
elaichenkov Apr 10, 2022
fc8c9b3
docs: update the wording of noElementHandle rule
elaichenkov Apr 11, 2022
3e8c4e8
rule: update message to match with other rule naming conventions
elaichenkov Apr 11, 2022
54725f3
rule: change noElementHandle to warn level
elaichenkov Apr 11, 2022
bad4c71
rule: noElementHandle change fixable to suggestion
elaichenkov Apr 11, 2022
4890c75
test: add valid tests for noElementHandle rule
elaichenkov Apr 11, 2022
7bb335b
rule: change type for noElementHandle to suggestion
elaichenkov Apr 11, 2022
03f016e
rule: update noElementHandle rule's message for suggestions
elaichenkov Apr 11, 2022
c776eed
rule: update noElementHandle with getRange method
elaichenkov Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add valid tests for noElementHandle rule
  • Loading branch information
@elaichenkov
elaichenkov committed Apr 11, 2022
commit 4890c75b96d688cb43ced2ce90b898b038cd1ae9
18 changes: 18 additions & 0 deletions test/no-element-handle.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,23 @@ new RuleTester().run('no-element-handle', rule, {

// page locator with action
valid('await page.locator("a").click();'),

// const $
valid('const $ = "text";'),

// $ as a method
valid('$("a");'),

// this.$ as a method
valid('this.$("a");'),

// internalPage.$ method
valid('internalPage.$("a");'),

// this.page.$$$ method
valid('this.page.$$$("div");'),

// page.$$$ method
valid('page.$$$("div");'),
],
});