Skip to content

Add test for no-skipped-test #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add test for no-skipped-test #101

merged 1 commit into from
Sep 23, 2022

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Sep 23, 2022

It stops working ESLint in v0.11.1. Here is the error log. Can you please release 0.11.2 or 0.12.0?

> eslint '**/*.ts'


Oops! Something went wrong! :(

ESLint: 8.23.1

TypeError: Cannot read properties of undefined (reading 'type')
Occurred while linting /Users/nix6839/programming/playground/playwrigt-lint-error/tests/error-lint.test.ts:4
Rule: "playwright/no-skipped-test"
    at isLiteral (/Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint-plugin-playwright@0.11.1_eslint@8.23.1/node_modules/eslint-plugin-playwright/lib/utils/ast.js:41:18)
    at isStringLiteral (/Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint-plugin-playwright@0.11.1_eslint@8.23.1/node_modules/eslint-plugin-playwright/lib/utils/ast.js:47:12)
    at getSkipRange (/Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint-plugin-playwright@0.11.1_eslint@8.23.1/node_modules/eslint-plugin-playwright/lib/rules/no-skipped-test.js:20:39)
    at Object.fix (/Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint-plugin-playwright@0.11.1_eslint@8.23.1/node_modules/eslint-plugin-playwright/lib/rules/no-skipped-test.js:38:67)
    at normalizeFixes (/Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint@8.23.1/node_modules/eslint/lib/linter/report-translator.js:193:28)
    at /Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint@8.23.1/node_modules/eslint/lib/linter/report-translator.js:223:22
    at Array.map (<anonymous>)
    at mapSuggestions (/Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint@8.23.1/node_modules/eslint/lib/linter/report-translator.js:217:10)
    at /Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint@8.23.1/node_modules/eslint/lib/linter/report-translator.js:365:55
    at Object.report (/Users/nix6839/programming/playground/playwrigt-lint-error/node_modules/.pnpm/eslint@8.23.1/node_modules/eslint/lib/linter/linter.js:1085:41)
 ELIFECYCLE  Command failed with exit code 2.

@mskelton mskelton merged commit 41d6c7d into playwright-community:main Sep 23, 2022
@nix6839 nix6839 deleted the more-test-skip-test branch September 24, 2022 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants