no-useless-not is unaware of `enabled`/`visible` parameter

[karyon]

this reports "Unexpected usage of not.toBeVisible(). Use toBeHidden() instead", but only toBeVisible has the parameter.

let visible = false;
// reports no-useless-not
await expect(page.locator('#selector')).not.toBeVisible({ visible });

same for toBeEnabled.

The lint was added in #81. Shortly thereafter, playwright 1.26 was released which added these parameters.

[mskelton]

@karyon I added support for this in #264 with a pile of test cases and also support for auto-fixing if a boolean literal is passed as the argument:

await expect(page.locator('#selector')).not.toBeVisible({ visible: false });
// becomes
await expect(page.locator('#selector')).toBeVisible();

await expect(page.locator('#selector')).not.toBeVisible({ visible: true });
// becomes
await expect(page.locator('#selector')).toBeHidden();

await expect(page.locator('#selector')).toBeVisible({ visible: true });
// becomes
await expect(page.locator('#selector')).toBeVisible();

If the argument for visible or enabled isn't a simple boolean literal, we won't report an error given that we can't determine the value of the provided argument.

Unlikely anyone would do that, but if they do, the rule will auto fix it! 😄

[github-actions]

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[karyon]

That was quick, thanks a lot!