Modularize play-json / play-functional / play-datacommons #754
Conversation
This module is the first dependency which needs to be extracted to extract play-json.
Second dependency which has to be extracted to be able to make play-json standalone
…k to play core project because I want to keep Forms as is for now
This module is the first dependency which needs to be extracted to extract play-json.
Second dependency which has to be extracted to be able to make play-json standalone
…k to play core project because I want to keep Forms as is for now
[playframework#754] Disable bonecp release helper threads
|
+1 |
Modularize play-json / play-functional / play-datacommons
| publishArtifact in (Compile, packageSrc) := true | ||
| ) | ||
| ).settings(com.typesafe.sbtscalariform.ScalariformPlugin.defaultScalariformSettings: _*) | ||
| .dependsOn(IterateesProject, FunctionalProject, DataCommonsProject) |
There was a problem hiding this comment.
Why is the json API depending on the Iteratee module?
There was a problem hiding this comment.
good question ;)
This is due to your Enumeratees which are in JSON object, Julien :D
I wondered if I should move them but it would have broken the API.
So first step was to create module like that and see if we keep this dep on
iteratees which is a bit superficial.
But anyway, this doesn't bring unwanted deps to people, this is pure
scala...
On Fri, Feb 22, 2013 at 12:04 PM, Julien Richard-Foy <
notifications@github.com> wrote:
In framework/project/Build.scala:
)- ).settings(com.typesafe.sbtscalariform.ScalariformPlugin.defaultScalariformSettings: _*)
- lazy val JsonProject = Project(
"Play-Json",file("src/play-json"),settings = buildSettingsWithMIMA ++ Seq(previousArtifact := Some("play" % {"play-json_"+previousScalaVersion} % previousVersion),libraryDependencies := jsonDependencies,publishTo := Some(playRepository),scalacOptions ++= Seq("-encoding", "UTF-8", "-Xlint","-deprecation", "-unchecked", "-feature"),publishArtifact in packageDoc := buildWithDoc,publishArtifact in (Compile, packageSrc) := true)- ).settings(com.typesafe.sbtscalariform.ScalariformPlugin.defaultScalariformSettings: _*)
- .dependsOn(IterateesProject, FunctionalProject, DataCommonsProject)
Why is the json API depending on the Iteratee module?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/754/files#r3114414.
There was a problem hiding this comment.
Maybe we should put these Enumeratees in the play artifact?
There was a problem hiding this comment.
On Fri, Feb 22, 2013 at 12:12 PM, Julien Richard-Foy <
notifications@github.com> wrote:
In framework/project/Build.scala:
)- ).settings(com.typesafe.sbtscalariform.ScalariformPlugin.defaultScalariformSettings: _*)
- lazy val JsonProject = Project(
"Play-Json",file("src/play-json"),settings = buildSettingsWithMIMA ++ Seq(previousArtifact := Some("play" % {"play-json_"+previousScalaVersion} % previousVersion),libraryDependencies := jsonDependencies,publishTo := Some(playRepository),scalacOptions ++= Seq("-encoding", "UTF-8", "-Xlint","-deprecation", "-unchecked", "-feature"),publishArtifact in packageDoc := buildWithDoc,publishArtifact in (Compile, packageSrc) := true)- ).settings(com.typesafe.sbtscalariform.ScalariformPlugin.defaultScalariformSettings: _*)
- .dependsOn(IterateesProject, FunctionalProject, DataCommonsProject)
Maybe we should put these Enumeratees in the play artifact?
That was my first idea but didn't want to break it at first...
But this seems logical!
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/754/files#r3114481.
No description provided.