[#1924] Sane c3p0 logging #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you create an issue in lighthouse? |
Contributor
Author
|
Sure. Done. |
Contributor
|
FYI, we also set c3p0 logging to INFO on production, as some errors are extremely hard to find without it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
play1 simultaneously uses c3p0 as its default Connection pool but sends all c3p0 logging to
/dev/null(metaphorically speaking). That renders applications which experience database problems very difficult to debug.c3p0's logging is unreasonably verbose at DEBUG/FINE/TRACE levels, but is reasonably quiet at INFO and very quiet at WARN or above, unless something really breaks. The library is intended to be logged at INFO. But it does emit an full configuration dump on pool initialization at INFO.
Presumably someone got annoyed by c3p0's logging and (insanely) just swept it away all at once.
This pull request restores c3p0 logging at WARN level. From the perspective of a guy who often gets c3p0 support requests, I'd prefer logging at INFO, so users can view and report their pool configurations. But given the extreme prejudice with which c3p0 logging was eliminated, I figure I should be grateful to even get logging at WARN. (I'd be glad to update this with a commit that logs at INFO instead, if you are amenable!)