[#1916] Get Java version from application.conf #835
Conversation
getJavaVersion() spawns a subprocess, which breaks Upstart (http://upstart.ubuntu.com/) which expects Play to fork exactly none, once or twice, depending on which "expect" stanza you use.
|
I understand the goal here, but this change would be very inconvenient. Perhaps we can add a command line argument to specify the Java version instead, and have it fall back to the current behavior if the argument isn't provided. That would be much more convenient for the majority of use cases. |
|
@gpgekko I agree, problem with this PR is that "java.source" version is not necessary the version of the running JVM |
I'll amend the PR, but first please answer these questions:
|
|
Flag-only. As for the name, I'm not sure, there seem to be mixed conventions ( |
- add test for case where jvm_version flag is supplied - add test for case where jvm_version flag is omitted - add Python mock library for new tests - remove jpda.port re-initialisation in application.py's check_jpda() since this value is already initialised in __init__() - add contextual documentation in cmd-start.txt
|
Perhaps change the title of the pull request for future reference. The rest looks fine to me. |
|
👍 |
|
I don't think this got merged yet? |
|
Those buttons are too close together. |
xael-fry
changed the title
There was a problem hiding this comment.
I think he might be referencing that in #835 (comment)
[#1916] Get Java version from application.conf
|
Merged and pushed in master and 1.3.x. |
3 participants
getJavaVersion()(introduced in 8f5e3e5) spawns a subprocess, which bumps the PID count, which breaks Upstart, the latter which expects Play to fork exactly none, once or twice, depending on whichexpectstanza you use.