-
Notifications
You must be signed in to change notification settings - Fork 223
Do not reset camera clearColor in viewer AR mode #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
That is definitely intentional, and the whole point of AR mode is to see passthrough and to achieve that you need to set the camera's clear colour to transparent. |
I see your point. It might be good to make this configurable as a viewer setting. The more background-encompassing a splat is, the more jarring it is to see your physical environment in the rendering. Another solution might be to optionally have a transparency falloff around the POI when in AR mode. |
The most simple solution is to provide VR and AR buttons instead of a single XR one and let users choose which experience type they want. |
both VR and AR buttons are present already, the problem is 99% of people have a phone and 1% of people have a VR headset. When you hit the VR button on a phone it defaults to a split screen stereoscopic, which isnt a very good first-run experience. |
So we could hide VR button on the mobile phones, and only offer AR button where it is supported. And on headsets offer both options, and disable unsupported session types (e.g. on Desktop and AVP, AR is not available). |
On mobile we could continue to offer AR and VR modes to the user. Both modes would work like the current AR mode, but we would clear the background in the case of VR mode. Would this limit google cardboard-type experience. Does anyone still use this? (Or is there a modern alternative?) @Maksims does this make sense? Can we "detect" mobile devices easily? |
On mobile, offering a VR mode probably does not make much sense. Cardboard is not a thing anymore, and Samsung Gear VR is not either. When rendering using AR but clearing the background - does achieve pretty much same as VR, but has some performance drawbacks as it has to use some device resources for MR related things. |
Currently the viewer does a strange thing in AR mode - it sets the camera clear color to fully transparent, which has the effect of showing you your physical environment in AR mode wherever there is transparency in your scene. This simply deletes this behavior. I don't have an intuition for why it exists previously but feel free to ignore this PR if it's essential for something. In testing it in my viewer app it seems to work fine (Pixel 7 Chrome AR mode).