[FIX] Fix EventHandle cleanup in annotation script #8337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a runtime error when reloading scenes using the annotation script (e.g., the 3D Gaussian Splat annotations example in the Examples Browser).
The
_unregisterAnnotationmethod was callinghandle.unbind()on event handles, but PlayCanvas engine'sEventHandleclass usesoff()to unsubscribe, notunbind()(which is the method used by@playcanvas/observer).Error before fix:
Fixes #8331
Checklist