Skip to content

Allow changing unified property without disabling component #8334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mvaligursky merged 1 commit into from
Jan 5, 2026
Merged

Allow changing unified property without disabling component #8334

mvaligursky merged 1 commit into from
Jan 5, 2026

Conversation

@mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Jan 5, 2026 •
edited
Loading

Allow the GSplatComponent.unified property to be changed at runtime without requiring manual disable/enable of the component.

Changes

  • Modified unified setter to automatically destroy and recreate internal data (instance/placement) when the value changes
  • Simplified global-sorting example to demonstrate direct property assignment

Before

comp.enabled = false;
comp.entity.enabled = false;
comp.unified = true;
comp.enabled = true;
comp.entity.enabled = true;

After

comp.unified = true;

@mvaligursky mvaligursky self-assigned this Jan 5, 2026
@mvaligursky mvaligursky added enhancement Request for a new feature area: graphics Graphics related issue labels Jan 5, 2026
@mvaligursky mvaligursky requested a review from a team January 5, 2026 16:01
willeastcott
willeastcott reviewed Jan 5, 2026
View reviewed changes
src/framework/components/gsplat/component.js
*
* Note: Material handling differs between modes. When unified is false, use
* {@link GSplatComponent#material}. When unified is true, materials are shared per
* camera/layer - use {@link GSplatComponentSystem#getGSplatMaterial} instead.
Copy link
Contributor

@willeastcott willeastcott Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this naming. I prefer something like GSplatComponentSystem#getMaterial.

Copy link
Contributor Author

@mvaligursky mvaligursky Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep good point, will address separately.

@mvaligursky mvaligursky merged commit 0304e58 into main Jan 5, 2026
7 checks passed
@mvaligursky mvaligursky deleted the mv-gsplat-unified branch January 5, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@mvaligursky mvaligursky

Labels

area: graphics Graphics related issue enhancement Request for a new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvaligursky @willeastcott