Skip to content

Added node name to batch insertion/removal assert message #8322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willeastcott merged 1 commit into from
Dec 27, 2025
Merged

Added node name to batch insertion/removal assert message #8322

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/scene/batching/batch-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ class BatchManager {

insert(type, groupId, node) {
const group = this._batchGroups[groupId];
Debug.assert(group, `Invalid batch ${groupId} insertion`);
Debug.assert(group, `Invalid batch ${groupId} insertion with node: "${node.name}"`);

if (group) {
if (group._obj[type].indexOf(node) < 0) {
Expand All @@ -246,7 +246,7 @@ class BatchManager {

remove(type, groupId, node) {
const group = this._batchGroups[groupId];
Debug.assert(group, `Invalid batch ${groupId} insertion`);
Debug.assert(group, `Invalid batch ${groupId} removal with node: "${node.name}"`);

if (group) {
const idx = group._obj[type].indexOf(node);
Expand Down