Skip to content

Conversation

@raytranuk
Copy link
Contributor

@raytranuk raytranuk commented Mar 19, 2020

Related to: playcanvas/editor#12

API changes:
pc.ElementComponent pc.ELEMENTTYPE_TEXT outlineThickness property's max value extended from 1.0 to 5.0

I confirm I have signed the Contributor License Agreement.

@raytranuk raytranuk requested a review from a team March 19, 2020 17:57
@raytranuk raytranuk self-assigned this Mar 19, 2020
@willeastcott willeastcott added the area: ui UI related issue label Apr 15, 2020
@raytranuk raytranuk marked this pull request as ready for review April 17, 2020 13:46
This reverts commit 5722268.
This reverts commit c65200c.
@raytranuk raytranuk marked this pull request as draft June 11, 2020 09:07
@raytranuk
Copy link
Contributor Author

Closing because this is not a viable solution on mobile devices without a proposed WebGL extension: https://www.khronos.org/registry/webgl/extensions/proposals/EXT_shader_framebuffer_fetch/ (also mentioned here: KhronosGroup/WebGL#3144) - which would enable text rendering effects in far fewer passes.

@raytranuk raytranuk closed this Apr 30, 2021
@yaustar
Copy link
Collaborator

yaustar commented Apr 30, 2021

Could we allow for WebGL2 and limit the thickness for WebGL1?

@willeastcott willeastcott deleted the thicker_text_outlines branch January 31, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui UI related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants