-
Notifications
You must be signed in to change notification settings - Fork 129
[FIX] Restore collision gizmo render style #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes collision gizmo render styling by preventing the "behind" material's alpha value from being incorrectly overwritten and removes redundant property settings.
- Removes the incorrect
uColorparameter set on the behind mesh instance material that was overwriting the correct alpha value - Removes redundant
drawToDepth = falsesettings since this is already handled by the material'sdepthWriteproperty - Removes various redundant
castShadow = falseproperty settings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #1651
Avoid overwriting the 'behind' alpha value.
Also, strip some redundant property sets (
MeshInstance#castShadowdefaults tofalseandMeshInstance#drawToDepthdoesn't exist).