Skip to content

Conversation

@willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Jan 3, 2026

Fixes #1651

Avoid overwriting the 'behind' alpha value.

image

Also, strip some redundant property sets (MeshInstance#castShadow defaults to false and MeshInstance#drawToDepth doesn't exist).

@willeastcott willeastcott self-assigned this Jan 3, 2026
@willeastcott willeastcott added bug Something isn't working area: viewport labels Jan 3, 2026
@willeastcott willeastcott marked this pull request as ready for review January 3, 2026 17:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes collision gizmo render styling by preventing the "behind" material's alpha value from being incorrectly overwritten and removes redundant property settings.

  • Removes the incorrect uColor parameter set on the behind mesh instance material that was overwriting the correct alpha value
  • Removes redundant drawToDepth = false settings since this is already handled by the material's depthWrite property
  • Removes various redundant castShadow = false property settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@willeastcott willeastcott merged commit 9a2d74b into main Jan 5, 2026
3 checks passed
@willeastcott willeastcott deleted the fix-col-giz branch January 5, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: viewport bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor - collision elements obscure render elements

3 participants