Update asset types documentation to include additional asset types #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willeastcott
reviewed
May 9, 2025
willeastcott
reviewed
May 9, 2025
willeastcott
reviewed
May 9, 2025
willeastcott
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following asset types are undocumented:
I'm going off the list of assets documented here: https://api.playcanvas.com/engine/classes/Asset.html#constructor
This PR adds
binary,bundle, andscriptto the "Asset Types" table.I did not include
modelandcontainer. My understanding ismodelis replaced byrender. I'm not super familiar with howcontainerworks and if it would be worth including.binary
Can be useful including binary as some users try to import
.gltfand are confused that it's imported as a binary.bundle
This is a new feature that landed in 2024.
script
I was kind of surprised this wasn't mentioned.
Misc
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.