Additional name and script ref in error reporting #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `AttributeParser` and `ScriptParser` to include `scriptName` and `attributeName` in error handling, providing better context for parsing errors. - Refactored `ParsingError` to include additional context in error messages, improving clarity on the source of errors. - Modified `JSDocParser` to pass `scriptName` during attribute extraction, ensuring consistent error reporting across scripts. - Enhanced tests to verify the presence of `scriptName` in error outputs, ensuring comprehensive error tracking.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error reporting by propagating script and attribute names into parsing errors throughout the codebase. The main goal is to provide better debugging context by including scriptName and attributeName information in error messages and error objects.
- Enhanced
ParsingErrorconstructor to accept and storescriptNameandattributeNamecontext - Modified parsing methods to pass script and attribute names through the call chain
- Updated error generation to include contextual information for better debugging
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/parsers/parsing-error.js |
Enhanced constructor to accept script/attribute names and improved toString() formatting |
src/parsers/script-parser.js |
Modified to pass scriptName through parsing calls and updated error creation |
src/parsers/attribute-parser.js |
Updated methods to accept and use scriptName/attributeName parameters |
src/index.js |
Modified to pass scriptName during attribute extraction and fixed attribute position calculation |
test/tests/valid/export.test.js |
Added test assertions to verify scriptName presence in error objects |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…anvas/attribute-parser into fix-correct-jsdoc-line-end
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances error reporting and context handling throughout the attribute and script parsing logic. The main focus is on propagating
scriptNameandattributeNameinformation into parsing errors, making debugging and error tracing much easier. Additionally, some minor bug fixes and improvements are included in how attribute positions are calculated.ParsingErrorto include additional context in error messages, improving clarity on the source of errors.JSDocParserto passscriptNameduring attribute extraction, ensuring consistent error reporting across scripts.scriptNamein error outputs, ensuring comprehensive error tracking.