Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/publish events simple #181

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

demogorgonzola
Copy link
Contributor

Fixes #103

This is a much simpler solution compared to #172.
It takes the "CheckedPublished" middleware and if any route concerns itself with viewing anything associated with an unpublished event, a 401 is sent to the user.

An additional "Publish" and "Unpublish" button have been added to the lead and admin event view.

+ tests for the child of event to event method
+ migration for 'published_at' column on events
+ tests for authorization of published/unpublished events
Copy link
Contributor

@Meleeman01 Meleeman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, but i'm thinking the published unpublished logic should be in the controller

laravel/app/Http/Middleware/CheckPublished.php Outdated Show resolved Hide resolved
Copy link
Contributor

@Meleeman01 Meleeman01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything works as intended, and i understand the design decisions for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to publish events
2 participants