Conversation
8 tasks
|
Analyzed 1026 tracker script variants for size changes. Main variants:
Important legacy variants:
Summary:
In total, 114 variants brotli size increased and 147 variants brotli size decreased. |
apata
added
the
tracker-release: patch
apata
commented
Jul 8, 2025
RobertJoonas
reviewed
Jul 9, 2025
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
A few comments inline, but other than that, I think this will get us to a good place! Nice job!
RobertJoonas
approved these changes
Jul 11, 2025
Contributor
RobertJoonas
left a comment
RobertJoonas
left a comment
There was a problem hiding this comment.
Neat solution from this tricky situation. LGTM! 👍
This was referenced Jul 14, 2025
apata
deleted the
script-v2/sync-event-props-path-for-special-goals-in-ingestion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
If this PR is merged, then special path-based system goals (new term / module, name up for debate) won't need to have event.props.path defined during tracking requests.
These goals/events are "WP Form Completions", "Form: Submission", "404".
It will instead be set on receiving the event to be the same as event.pathname, unless event.props.path is explicitly defined.
We don't override it when it is explicitly defined to remain backwards compatible with users that are already sending these events with a particular value.
From our side, we can't distinguish intentional values and unintentional values for event.props.path, so the benefits of the sync will mostly apply to new customers, or customers that begin using these features after this PR is merged.
This approach stores the same pathname twice on our side for special path-based events, but the rate of these special events is many magnitudes less than rate of other events, so the duplicated data is insignificant in the grand scheme of things.
Todo after merge
Tests
Changelog
Documentation
Dark mode