Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Allow for third parameter in no-hooks-from-ancestor-modules #231

Merged
merged 1 commit into from
Jun 4, 2022
Merged

Fix: Allow for third parameter in no-hooks-from-ancestor-modules #231

merged 1 commit into from
Jun 4, 2022

Conversation

Krinkle
Copy link
Contributor

@Krinkle Krinkle commented May 13, 2022

Fixes #230.

@coveralls
Copy link

coveralls commented May 13, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling e0297c3 on Krinkle:fix-module-arg into f3878c1 on platinumazure:master.

bmish
bmish approved these changes May 13, 2022
View reviewed changes
lib/rules/no-hooks-from-ancestor-modules.js Outdated Show resolved Hide resolved
@platinumazure
Copy link
Owner

Thanks @Krinkle for the PR! I'll try to review this weekend. Looks good at a very quick glance.

@platinumazure platinumazure merged commit 3fcc906 into platinumazure:master Jun 4, 2022
@platinumazure
Copy link
Owner

@Krinkle Thanks for contributing and for your patience!

@Krinkle Krinkle deleted the fix-module-arg branch June 4, 2022 21:40
Krinkle added a commit to wikimedia/eslint-config-wikimedia that referenced this pull request Feb 24, 2023
@Krinkle
build: Ensure eslint-plugin-qunit 7.3.0 or later
d565f2b 
The bug fix at platinumazure/eslint-plugin-qunit#231
was released in March 2022 as part of 7.3.0.

Fresh installs of eslint-config-wikimedia already expand `^7.2.0`
to 7.3.4, but I'd rather set a minimum so that the next propagation
of eslint-config-wikimedia will naturally update this, because
otherwise npm is conservative nowadays and only updates when forced
to or when doing a full rebuild after deleting one's lock file.
@Krinkle Krinkle mentioned this pull request Feb 24, 2023
Merged
Krinkle added a commit to wikimedia/eslint-config-wikimedia that referenced this pull request Feb 24, 2023
@Krinkle
build: Ensure eslint-plugin-qunit 7.3.0 or later
ee7d3ae 
The bug fix at platinumazure/eslint-plugin-qunit#231
was released in March 2022 as part of 7.3.0.

Fresh installs of eslint-config-wikimedia already expand `^7.2.0`
to 7.3.4, but I'd rather set a minimum so that the next propagation
of eslint-config-wikimedia will naturally update this, because
otherwise npm is conservative nowadays and only updates when forced
to or when doing a full rebuild after deleting one's lock file.
jdforrester pushed a commit to wikimedia/eslint-config-wikimedia that referenced this pull request Feb 27, 2023
@Krinkle
qunit: Update eslint-plugin-qunit to 7.3.0 or later (#491)
b81c835 
The bug fix at platinumazure/eslint-plugin-qunit#231
was released in March 2022 as part of 7.3.0.

Fresh installs of eslint-config-wikimedia already expand `^7.2.0`
to 7.3.4, but I'd rather set a minimum so that the next propagation
of eslint-config-wikimedia will naturally update this, because
otherwise npm is conservative nowadays and only updates when forced
to or when doing a full rebuild after deleting one's lock file.
wmfgerrit pushed a commit to wikimedia/mediawiki that referenced this pull request Apr 12, 2023
@Krinkle
build: Update eslint-plugin-qunit to ^7.3.0
0fcd7a9 
The 7.3.0 version, released in March 2022, fixed an issue where the
`hooks` parameter to `QUnit.module` sometimes received a unexpected
lint warning due to misunderstanding what the parameter is used for.

platinumazure/eslint-plugin-qunit#231

The existing range ^7.2.0 range, as dependency of
eslint-config-wikimedia, would already expand to 7.3.4 if we build
package-lock.json, but since npm is conservative nowadays, it hasn't
been bumped yet.

Several other MediaWiki repos already use the newer version, which
likely did a rebuild at some point in the last 11 months.

<https://codesearch.wmcloud.org/deployed/?q=eslint-plugin-qunit-7.3...tg>

Change-Id: I696ed00372f29b4e1a9c67e71e5af03c9c7acd54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive for no-hooks-from-ancestor-modules
4 participants
@Krinkle @coveralls @platinumazure @bmish