Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Add no-assert-equal to recommended config #194

Merged
merged 5 commits into from
Aug 28, 2021
Merged

Breaking: Add no-assert-equal to recommended config #194

merged 5 commits into from
Aug 28, 2021

Conversation

bmish
Copy link
Collaborator

@bmish bmish commented Jun 28, 2021

@coveralls
Copy link

coveralls commented Jun 28, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling f7477ff on bmish:recommended-v7 into f045931 on platinumazure:master.

platinumazure
platinumazure approved these changes Jun 28, 2021
View reviewed changes
Copy link
Owner

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for getting this done!

@platinumazure
Copy link
Owner

@bmish Mind resolving the conflicts here? Thanks!

@platinumazure platinumazure merged commit 32fa473 into platinumazure:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure platinumazure approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable no-assert-equal as recommended rule in v7?
3 participants
@bmish @coveralls @platinumazure