Update: no-hooks-from-ancestor-modules works with arrow module callba…

…cks (#267) Fixes #246
platinumazure · Nov 20, 2022 · f02b60f · f02b60f
1 parent bdb2254
commit f02b60f
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 2 deletions.
diff --git a/lib/rules/no-hooks-from-ancestor-modules.js b/lib/rules/no-hooks-from-ancestor-modules.js
@@ -47,7 +47,7 @@ module.exports = {
                 callExpressionNode.parent.parent &&
                 callExpressionNode.parent.parent.type === "BlockStatement" &&
                 callExpressionNode.parent.parent.parent &&
-                callExpressionNode.parent.parent.parent.type === "FunctionExpression" &&
+                ["FunctionExpression", "ArrowFunctionExpression"].includes(callExpressionNode.parent.parent.parent.type) &&
                 callExpressionNode.parent.parent.parent.parent &&
                 callExpressionNode.parent.parent.parent.parent.type === "CallExpression" &&
                 utils.isModule(callExpressionNode.parent.parent.parent.parent.callee);

diff --git a/tests/lib/rules/no-hooks-from-ancestor-modules.js b/tests/lib/rules/no-hooks-from-ancestor-modules.js
@@ -30,7 +30,7 @@ function createError({ invokedMethodName, usedHooksIdentifierName }) {
 // Tests
 //------------------------------------------------------------------------------
 
-const ruleTester = new RuleTester();
+const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: "latest" } });
 ruleTester.run("no-hooks-from-ancestor-modules", rule, {
 
     valid: [
@@ -244,6 +244,38 @@ ruleTester.run("no-hooks-from-ancestor-modules", rule, {
             ]
         },
 
+        // https://github.com/platinumazure/eslint-plugin-qunit/issues/246
+        {
+            code: `
+                QUnit.module("module-a", function (hooks) {
+                    QUnit.module("module-b", () => {
+                        hooks.beforeEach(function () {});
+                    });
+                });
+            `,
+            errors: [
+                createError({
+                    invokedMethodName: "beforeEach",
+                    usedHooksIdentifierName: "hooks"
+                })
+            ]
+        },
+        {
+            code: `
+                QUnit.module("module-a", (hooks) => {
+                    QUnit.module("module-b", () => {
+                        hooks.beforeEach(() => {});
+                    });
+                });
+            `,
+            errors: [
+                createError({
+                    invokedMethodName: "beforeEach",
+                    usedHooksIdentifierName: "hooks"
+                })
+            ]
+        },
+
         {
             // TypeScript: module callback is adding a type to `this`
             code: `