quotes workflow name since the name includes a comma #4245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwcarlson
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
PR #4244 introduced an issue with PR comments workflow
What's changed
TL;DR - adds quotes to the name of dependency workflow
The workflow that adds PR comments (comment-on-pr.yaml) is triggered based on the conclusion of the (formerly named) get-pr-info,yaml workflow. Github uses the
nameproperty of the parent workflow to identify it. I changed that property toGet PR URL, start dependent jobsto more accurately reflect what it does, but now the comment workflow sees that as two different workflows. Quoting the workflownamecorrects the issue.