- 
                Notifications
    You must be signed in to change notification settings 
- Fork 8
Improve build time performance #438
Improve build time performance #438
Conversation
| Hello, and thank you for contributing to the Upsun demo project! Setting up testsUntil all tests pass, a pull request will not be merged. Build tests for combinations of Python and Node.js will happen automatically, and must pass in order to merge. Failing testsIf your PR is failing, see the Running tests section of the README for troubleshooting details. Reviewing these changes locally:
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bun.lockb is an older format:
https://bun.com/docs/install/lockfile
Bun v1.2 changed the default lockfile format to the text-based bun.lock. Existing binary bun.lockb lockfiles can be migrated to the new format by running bun install --save-text-lockfile --frozen-lockfile --lockfile-only and deleting bun.lockb.
| 
 @pjcdawkins this has been corrected | 
| 
 Just noticed that Upsun apps use version 1.1 of bun which may be incompatible with this lock file version. This below corrects the issue, but I just encountered my first test that was back to 2.5 minutes. However, it's unclear if it was due to this change or due to deploying at a time where services were weighed down a bit.         dependencies:
          nodejs:
            bun: "v1.2.23" | 
| I think it should continue to work with the built in bun (1.1) and the text lock file, 1.2 just made the text file default | 
| 
 I set my local bun to match Upsun's default Bun version and reverted the Upsun config to use Upsun's default bun version. How do you feel about the latest state of this mr @pjcdawkins ? | 
piptouvThe demo
runthroughpipeline has consistently shown a reduction of ~1 minute for first deployment completions (upsun push-> deployed)The demo
runthroughpipeline has consistently shown that subsequent deployments (merge, branch, etc) take about ~1m15s