-
Notifications
You must be signed in to change notification settings - Fork 39
Add upload logo functionality and display account name and logo in navigation #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ep and AppGateway for unified storage connection per system
…hared access signatures
Approve Database Migration
|
Approve Database Migration
|
…public links to blob storage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Add support for uploading account logos and show the account names in the side menu and invitation emails. While the account name could previously be changed, it was not used anywhere. It is now displayed in the side menu with the logo to clearly indicate which account the user is currently logged into.
AVATARS_STORAGE_URL
toACCOUNT_MANAGEMENT_STORAGE_URL
for unified storage connection. This allows using the same connection string for both logos and avatars stored in the Account Management Blob Storage account.Downstream projects
Important: Infrastructure changes require careful deployment to avoid downtime
The environment variable
AVATARS_STORAGE_URL
has been renamed toACCOUNT_MANAGEMENT_STORAGE_URL
in the AppGateway infrastructure.Deployment steps to avoid downtime:
ACCOUNT_MANAGEMENT_STORAGE_URL
environment variable to AppGateway with the same value as the existingAVATARS_STORAGE_URL
.github/workflows/app-gateway.yml
.github/workflows/account-management.yml
AVATARS_STORAGE_URL
environment variable using this:.github/workflows/cloud-infrastructure.yml
Note: This deployment sequence has not been tested. Please verify in your staging environment first.
Reminder: Deploying infrastructure in parallel with self-contained systems may revert the active Docker version to the previous one. This occurs because infrastructure deployment begins by retrieving the active version and adding it to the Bicep deployment. If a new version is deployed during this process, Bicep might revert it.
Checklist