Delegate primary script pathfinding and loading to PHP #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .strip_prefix("/") | ||
| .map_err(EmbedException::RelativizeError)?; | ||
|
|
||
| match docroot.join(relative_uri).join("index.php").canonicalize() { |
There was a problem hiding this comment.
Does it always look for index.php file?
There was a problem hiding this comment.
At the moment, yes. It tries path + 'index.php' and, if it does not exist, tries path alone. It currently works in that order as it just checks existence and not that it is a file, so a directory would canonicalize also. I need to improve this a bit, but this part is a bit in-progress right now as I restructure it to resolve paths better.
simone-sanfratello
approved these changes
May 19, 2025
|
The tests will also need adjusting. Haven't fixed them yet to use the new design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three issues:
ResponseBuilder.header(...)method needs to append headers, not replace them