Skip to content

Conversation

@Qard
Copy link
Member

@Qard Qard commented May 14, 2025

  • Fix INI default loading
  • Fix $_SERVER paths
  • Do not supress errors when loading .node bindings file
  • Fix response build timing to not miss buffered headers
  • Improved safety of current request context retrieval

@Qard Qard requested review from ShogunPanda and mcollina May 14, 2025 10:28
@Qard Qard added the bug Something isn't working label May 14, 2025
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single nit, rest LGTM.

@Qard Qard force-pushed the various-fixes branch 9 times, most recently from 75c7fdd to 2b677dc Compare May 16, 2025 08:49
@Qard Qard force-pushed the various-fixes branch from 2b677dc to 7cbadcb Compare May 16, 2025 10:06
- Fix INI default loading
- Fix $_SERVER paths
- Do not supress errors when loading .node bindings file
- Fix response build timing to not miss buffered headers
- Improved safety of current request context retrieval
@Qard Qard force-pushed the various-fixes branch from 7cbadcb to 79ccd83 Compare May 16, 2025 10:08
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Qard Qard merged commit 3f04849 into main May 16, 2025
11 checks passed
@Qard Qard deleted the various-fixes branch May 16, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants