Skip to content

Improve docs #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2025
Merged

Improve docs #18

merged 1 commit into from
May 26, 2025

Conversation

Qard
Copy link
Member

@Qard Qard commented May 26, 2025

Added:

  • LICENSE file
  • API docs
  • Contributing, License, and Support sections to end of Readme

Changed:

  • Improved headers.entries/keys/values/forEach() to behave more like the MDN Headers type
  • Made PhpOptions.docroot, PhpRequestOptions.method and PhpResponseOptions.status optional
  • Made options inputs optional for both Response and Php constructors

@Qard Qard added the enhancement New feature or request label May 26, 2025
mcollina
mcollina approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Qard Qard merged commit 331c1b6 into main May 26, 2025
1 check passed
@Qard Qard deleted the improve-docs branch May 26, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda Awaiting requested review from ShogunPanda

@simone-sanfratello simone-sanfratello Awaiting requested review from simone-sanfratello

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qard @mcollina