Skip to content

Conversation

@erohinaelena
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @erohinaelena, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating and reorganizing project dependencies. The core change involves migrating the PlMultiSequenceAlignment component to its dedicated package, @milaboratories/multi-sequence-alignment, and updating the import path accordingly. This also includes a broad update of various @milaboratories and @platforma-sdk packages, along with a cleanup of esbuild related entries in the lockfile, ensuring the project uses the latest stable versions and a more modular component structure.

Highlights

  • Component Relocation: The PlMultiSequenceAlignment component has been moved from @platforma-sdk/ui-vue to its own dedicated package, @milaboratories/multi-sequence-alignment.
  • Dependency Updates: Numerous project dependencies have been updated, including @milaboratories/graph-maker and various @platforma-sdk packages, alongside a cleanup of esbuild related entries in the lockfile.
  • New Package Introduction: A new package, @milaboratories/multi-sequence-alignment, has been introduced and added to the project's dependency catalog.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies and refactors the import of PlMultiSequenceAlignment to use the new @milaboratories/multi-sequence-alignment package. The changes are correct and align with the goal of the pull request. I've added a couple of suggestions to improve code maintainability by sorting dependencies and imports alphabetically, which is a common best practice.

Comment on lines +10 to +22
"@platforma-sdk/model": ^1.45.30
"@platforma-sdk/ui-vue": ^1.45.31
"@platforma-sdk/workflow-tengo": ^5.6.0
"@platforma-sdk/block-tools": ^2.6.21
"@platforma-sdk/test": ^1.45.32
"@platforma-sdk/tengo-builder": ^2.3.9
"@platforma-sdk/package-builder": ^3.10.7
"@platforma-sdk/eslint-config": ^1.1.0
"@platforma-sdk/blocks-deps-updater": ^2.0.0


"@milaboratories/graph-maker": ^1.1.174
"@milaboratories/graph-maker": ^1.1.179
"@milaboratories/multi-sequence-alignment": ^1.45.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and readability, it's a good practice to keep the dependency catalog sorted alphabetically. This makes it easier to find packages and manage dependencies.

  "@milaboratories/graph-maker": ^1.1.179
  "@milaboratories/multi-sequence-alignment": ^1.45.1
  "@platforma-sdk/block-tools": ^2.6.21
  "@platforma-sdk/blocks-deps-updater": ^2.0.0
  "@platforma-sdk/eslint-config": ^1.1.0
  "@platforma-sdk/model": ^1.45.30
  "@platforma-sdk/package-builder": ^3.10.7
  "@platforma-sdk/test": ^1.45.32
  "@platforma-sdk/tengo-builder": ^2.3.9
  "@platforma-sdk/ui-vue": ^1.45.31
  "@platforma-sdk/workflow-tengo": ^5.6.0

Comment on lines 13 to 18
"@platforma-open/milaboratories.differential-clonotype-abundance.model": "workspace:*",
"@milaboratories/graph-maker": "catalog:",
"@milaboratories/multi-sequence-alignment": "catalog:",
"@platforma-sdk/ui-vue": "catalog:",
"@platforma-sdk/model": "catalog:",
"vue": "catalog:"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and readability, it's a good practice to keep dependencies sorted alphabetically. This makes it easier to find packages and manage dependencies.

Suggested change
"@platforma-open/milaboratories.differential-clonotype-abundance.model": "workspace:*",
"@milaboratories/graph-maker": "catalog:",
"@milaboratories/multi-sequence-alignment": "catalog:",
"@platforma-sdk/ui-vue": "catalog:",
"@platforma-sdk/model": "catalog:",
"vue": "catalog:"
"@milaboratories/graph-maker": "catalog:",
"@milaboratories/multi-sequence-alignment": "catalog:",
"@platforma-open/milaboratories.differential-clonotype-abundance.model": "workspace:*",
"@platforma-sdk/model": "catalog:",
"@platforma-sdk/ui-vue": "catalog:",
"vue": "catalog:"

Comment on lines +6 to 8
import { PlBtnGhost, PlSlideModal } from '@platforma-sdk/ui-vue';
import { PlMultiSequenceAlignment } from '@milaboratories/multi-sequence-alignment';
import { computed, ref } from 'vue';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better code organization and maintainability, it's recommended to sort import statements alphabetically. This helps in quickly locating imports and preventing merge conflicts.

import { PlMultiSequenceAlignment } from '@milaboratories/multi-sequence-alignment';
import { PlBtnGhost, PlSlideModal } from '@platforma-sdk/ui-vue';
import { computed, ref } from 'vue';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants