[canary] check-coverage@v4-beta — catalog bump must pass (do not merge)#98
Closed
PaulNewling wants to merge 1 commit into
Closed
[canary] check-coverage@v4-beta — catalog bump must pass (do not merge)#98PaulNewling wants to merge 1 commit into
PaulNewling wants to merge 1 commit into
Conversation
TEMPORARY, do not merge. Bumps the @platforma-sdk/workflow-tengo catalog entry (6.3.2 -> 6.4.0) — a runtime `catalog:` dependency of the .workflow package — with no source edits and no changeset. This is the exact shape that the old check-coverage (@v4) failed in #95. The added zz-canary workflow runs check-coverage@v4-beta directly. Expected: the canary job passes (a dependency bump never requires a changeset), while the normal @v4 'changeset coverage (diagnostic)' job still fails on .workflow.
There was a problem hiding this comment.
Code Review
This pull request updates the version of @platforma-sdk/workflow-tengo from 6.3.2 to 6.4.0 in pnpm-workspace.yaml. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose — temporary canary, do not merge
Validates the
check-coveragefix (milaboratory/github-ci#183, onv4-beta) against a real block before promotingv4-beta → v4.What this PR does
Bumps the
@platforma-sdk/workflow-tengocatalog entry6.3.2 → 6.4.0. That package is a runtimecatalog:dependency of.workflow. The PR touches no package source and adds no changeset — the exact shape that the old check failed in #95 (it flagged the untouched.workflow).How to read the result
The added
zz-canary check-coverage @v4-betajob runscheck-coverage@v4-betadirectly (the normal build chain can't —node-simple-pnpm.yaml@v4pins every action at@v4).canary check-coverage @v4-beta→ must be GREEN. A dependency bump never requires a changeset; the fixed action ignores it.changeset coverage (diagnostic)(the normal@v4job) → expected RED, flagging.workflow. That contrast is the proof: same PR, old action fails, fixed action passes.The
build/release jobs may be red (the catalog bump has no committed lockfile update, and the real chain installs--frozen-lockfile). Irrelevant here — only the canary job matters.Close without merging once observed.