-
Notifications
You must be signed in to change notification settings - Fork 0
dependencies update #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @vgpopov, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine dependency update, specifically bumping the version of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the @platforma-sdk/workflow-tengo dependency. While the change in pnpm-workspace.yaml is correct, the pnpm-lock.yaml file appears to have been manually and incorrectly updated. This has left the lock file in an inconsistent state, which can cause issues with build reproducibility. I've left a comment with details on how to fix this by regenerating the lock file.
pnpm-lock.yaml
Outdated
| '@platforma-sdk/block-tools': 2.6.22 | ||
| '@platforma-sdk/model': 1.45.35 | ||
| '@platforma-sdk/workflow-tengo': 5.6.1 | ||
| '@platforma-sdk/workflow-tengo': ^5.6.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lock file appears to have been manually edited, and it's now in an inconsistent state. This can lead to non-reproducible builds.
Specifically:
- This line introduces a version range (
^5.6.2) into a snapshot, where a concrete version is expected. Lock files should contain pinned versions. - Other parts of the lock file that reference
@platforma-sdk/workflow-tengohave not been updated and still point to version5.6.1. For example, thecatalogssection and theimporterssection for theworkflowpackage.
To fix this, please revert the manual changes to pnpm-lock.yaml and regenerate it by running pnpm install after updating pnpm-workspace.yaml.
dependencies update