This repository was archived by the owner on Dec 31, 2025. It is now read-only.
Updated directory structure and have versioned names #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarun87
approved these changes
Aug 6, 2018
Contributor
|
Can you make sure this question is resolved https://github.com/platform9/isv-tests/pull/26#pullrequestreview-144584751? |
Contributor
Author
|
Hi @vannrt thanks for taking a look, that comment is a bit old, had a chat with @dlipovetsky after that, have updated the PR message with the required directory structure |
vannrt
approved these changes
Aug 8, 2018
dlipovetsky
approved these changes
Aug 8, 2018
| var KubeDirName = filepath.Join("kubernetes", KubernetesVersion) | ||
| var FlannelDirName = filepath.Join("flannel", FlannelVersion) | ||
| var CNIDirName = filepath.Join("cni", CNIVersion) | ||
| var CniVersionInstallDir = filepath.Join(CNIBaseDir, CNIVersion) |
Contributor
There was a problem hiding this comment.
nit: CNIVersionInstallDir
Contributor
Author
There was a problem hiding this comment.
Thanks Daniel, will address in the next commit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
/var/cacheto have a consistent format.Updated directory names to have versions, to allow multiple installations to coexist
Have
/opt/binto have actual binaries and not symlinks (as we now have versioned binaries in cache)Also change the directory names for other binaries to follow the same pattern of
/var/cache/<parent-tool>/<tool>/<tool-version>/<tool-binary>(by parent tool we mean the one which uses the tool, e.g. ssh-provider is the parent tool for nodeadm, while nodeadm is the parent tool for kubernetes)contents of
/var/cachecontents of
/opt/bin