Draft
Conversation
philtk79
changed the title
akafazov
requested changes
Feb 20, 2026
Contributor
akafazov
left a comment
akafazov
left a comment
There was a problem hiding this comment.
I think this pr needs major refactoring.
pkg/subroutines/providersecret.go
Outdated
|
|
||
| // Use scoped kubeconfig when useAdminKubeconfig is false and FrontProxy is set. Also support legacy: | ||
| // extension-manager-operator with FrontProxyName set and no useAdminKubeconfig uses scoped. | ||
| useScoped := !ptr.Deref(pc.UseAdminKubeconfig, false) && operatorCfg.KCP.FrontProxyName != "" |
Contributor
There was a problem hiding this comment.
Why is frontProxyName relevant to this functionality?
pkg/subroutines/providersecret.go
Outdated
| // Use scoped kubeconfig when useAdminKubeconfig is false and FrontProxy is set. Also support legacy: | ||
| // extension-manager-operator with FrontProxyName set and no useAdminKubeconfig uses scoped. | ||
| useScoped := !ptr.Deref(pc.UseAdminKubeconfig, false) && operatorCfg.KCP.FrontProxyName != "" | ||
| legacyScoped := pc.Secret == "extension-manager-operator-kubeconfig" && operatorCfg.KCP.FrontProxyName != "" && pc.UseAdminKubeconfig == nil |
Contributor
There was a problem hiding this comment.
no hard-coded secret names
pkg/subroutines/providersecret.go
Outdated
Comment on lines
186
to
224
| apiExportName := pc.APIExportName | ||
| if apiExportName == "" { | ||
| apiExportName = *pc.EndpointSliceName | ||
| } | ||
| apiExportPath := pc.APIExportPath | ||
| if apiExportPath == "" { | ||
| apiExportPath = pc.Path | ||
| } | ||
| hostPort := fmt.Sprintf("https://%s-front-proxy.%s:%s", operatorCfg.KCP.FrontProxyName, operatorCfg.KCP.Namespace, operatorCfg.KCP.FrontProxyPort) | ||
| if pc.External { | ||
| hostPort = fmt.Sprintf("https://kcp.api.%s:%d", instance.Spec.Exposure.BaseDomain, instance.Spec.Exposure.Port) | ||
| } | ||
| hostPath := pc.Path | ||
| if apiExportPath != "" { | ||
| hostPath = apiExportPath | ||
| } | ||
| hostURL, err := url.JoinPath(hostPort, "clusters", hostPath) | ||
| if err != nil { | ||
| log.Error().Err(err).Msg("Failed to build host URL for scoped kubeconfig") | ||
| return ctrl.Result{}, errors.NewOperatorError(err, false, false) | ||
| } | ||
| namespace := "platform-mesh-system" | ||
| if ptr.Deref(pc.Namespace, "") != "" { | ||
| namespace = *pc.Namespace | ||
| } | ||
| caData := cfg.TLSClientConfig.CAData | ||
| if caData == nil { | ||
| caData = []byte{} | ||
| } | ||
| writeSecret := func(ctx context.Context, name, ns string, kubeconfigBytes []byte) error { | ||
| secret := &corev1.Secret{ | ||
| ObjectMeta: metav1.ObjectMeta{Name: name, Namespace: ns}, | ||
| } | ||
| _, createErr := controllerutil.CreateOrUpdate(ctx, r.client, secret, func() error { | ||
| secret.Data = map[string][]byte{"kubeconfig": kubeconfigBytes} | ||
| return nil | ||
| }) | ||
| return createErr | ||
| } |
Contributor
There was a problem hiding this comment.
this could be part of the kubeconfig_scoped.go functions
philtk79
force-pushed
the
feat/scoped-provider-kubeconfig
branch
from
f32017a to
e0ab1e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refers to #79