test(routes): add comprehensive tests for GET /peers/{peer_id}/context endpoint#532
Open
KevinNatera wants to merge 1 commit intoplastic-labs:mainfrom
Open
Conversation
Contributor
WalkthroughA comprehensive test suite was added for the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
tests/routes/test_peers.py (1)
968-1006: Consider consolidating duplicate self-observation coverage.
test_get_peer_context_basicandtest_get_peer_context_self_observationoverlap heavily; parametrizing or merging would reduce maintenance noise.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/routes/test_peers.py` around lines 968 - 1006, Merge or parametrize the duplicate assertions in test_get_peer_context_basic and test_get_peer_context_self_observation by consolidating the shared checks (response.status_code == 200, presence of "peer_id", "target_id", "representation", "peer_card", and the self-observation assertions that peer_id == target_id == test_peer.name) into a single test or a parametrized pytest function; update or remove one of the tests so the shared validation logic for the PeerContext schema and the default self-observation behavior is only implemented once while preserving any unique assertions, referencing the existing test functions test_get_peer_context_basic and test_get_peer_context_self_observation and the PeerContext expectations when refactoring.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/routes/test_peers.py`:
- Around line 1062-1063: The test currently allows any list for
data["peer_card"] but must enforce the schema that each item is a string; update
the assertion for peer_card so it remains allowed to be None or, if a list,
assert that every element in data["peer_card"] is an instance of str (e.g.,
using an all(...) check) to catch non-string regressions; locate and change the
assertion that references data["peer_card"] in tests/routes/test_peers.py.
- Around line 1443-1446: The POST that creates the target peer is currently
ignored; capture its response from
client.post(f"/v3/workspaces/{test_workspace.name}/peers", json={"name":
target_peer_name}) and assert success before proceeding: verify the
response.status_code (e.g., 201 or expected code) and that response.json()
contains the created peer (e.g., "name" == target_peer_name or expected id), so
downstream checks fail fast and show the real creation error.
---
Nitpick comments:
In `@tests/routes/test_peers.py`:
- Around line 968-1006: Merge or parametrize the duplicate assertions in
test_get_peer_context_basic and test_get_peer_context_self_observation by
consolidating the shared checks (response.status_code == 200, presence of
"peer_id", "target_id", "representation", "peer_card", and the self-observation
assertions that peer_id == target_id == test_peer.name) into a single test or a
parametrized pytest function; update or remove one of the tests so the shared
validation logic for the PeerContext schema and the default self-observation
behavior is only implemented once while preserving any unique assertions,
referencing the existing test functions test_get_peer_context_basic and
test_get_peer_context_self_observation and the PeerContext expectations when
refactoring.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7b749867-980e-4f85-93b8-39aa298c710c
📒 Files selected for processing (1)
tests/routes/test_peers.py
Comment on lines
+1062
to
+1063
| # peer_card should be a list of strings or None (no card set yet) | ||
| assert data["peer_card"] is None or isinstance(data["peer_card"], list) |
Contributor
There was a problem hiding this comment.
Strengthen peer_card type validation to match schema contract.
This currently accepts any list type; it won’t catch regressions where non-string items are returned.
Suggested fix
- assert data["peer_card"] is None or isinstance(data["peer_card"], list)
+ assert data["peer_card"] is None or (
+ isinstance(data["peer_card"], list)
+ and all(isinstance(item, str) for item in data["peer_card"])
+ )📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # peer_card should be a list of strings or None (no card set yet) | |
| assert data["peer_card"] is None or isinstance(data["peer_card"], list) | |
| # peer_card should be a list of strings or None (no card set yet) | |
| assert data["peer_card"] is None or ( | |
| isinstance(data["peer_card"], list) | |
| and all(isinstance(item, str) for item in data["peer_card"]) | |
| ) |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tests/routes/test_peers.py` around lines 1062 - 1063, The test currently
allows any list for data["peer_card"] but must enforce the schema that each item
is a string; update the assertion for peer_card so it remains allowed to be None
or, if a list, assert that every element in data["peer_card"] is an instance of
str (e.g., using an all(...) check) to catch non-string regressions; locate and
change the assertion that references data["peer_card"] in
tests/routes/test_peers.py.
Comment on lines
+1443
to
+1446
| client.post( | ||
| f"/v3/workspaces/{test_workspace.name}/peers", | ||
| json={"name": target_peer_name}, | ||
| ) |
Contributor
There was a problem hiding this comment.
Assert target peer creation before using it in downstream checks.
The setup call result is ignored, which can obscure root cause when this test fails later.
Suggested fix
- client.post(
+ create_target_response = client.post(
f"/v3/workspaces/{test_workspace.name}/peers",
json={"name": target_peer_name},
)
+ assert create_target_response.status_code in [200, 201]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tests/routes/test_peers.py` around lines 1443 - 1446, The POST that creates
the target peer is currently ignored; capture its response from
client.post(f"/v3/workspaces/{test_workspace.name}/peers", json={"name":
target_peer_name}) and assert success before proceeding: verify the
response.status_code (e.g., 201 or expected code) and that response.json()
contains the created peer (e.g., "name" == target_peer_name or expected id), so
downstream checks fail fast and show the real creation error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: test(routes): Add comprehensive tests for
GET /peers/{peer_id}/contextendpointWhat Changed
Added 20 new tests to
tests/routes/test_peers.pycovering theGET /workspaces/{workspace_id}/peers/{peer_id}/contextendpoint (get_peer_context).Why This Contribution
While exploring the codebase, I noticed the
get_peer_contextendpoint had zero test coverage. This endpoint is actually important — it was added specifically to let callers retrieve a peer's representation and peer card in a single round-trip rather than two separate requests, which is a meaningful latency optimization for real-world agent applications.Without tests, any future refactor or change to this endpoint could silently break it. Given Honcho's production use and the fact that this is a convenience endpoint building on two other covered endpoints, it felt like exactly the kind of gap that's worth closing.
What Problem It Solves
ge/levalidation onsearch_top_k,search_max_distance, andmax_conclusionsactually enforces the expected 422 responses/contextreturns the samerepresentationandpeer_cardvalues as calling/representationand/cardseparately — catching any divergence in logicTest Coverage Added
How to Review
All changes are confined to
tests/routes/test_peers.py. The tests follow the same patterns as the existing test suite (same fixtures, same assertion style, same import patterns). No production code was modified.Closes #(no issue — this is proactive test coverage for an untested endpoint)
cc @ajspig
Summary by CodeRabbit