Only add -msse4.2 if it is supported by the compiler#29
Closed
cottsay wants to merge 1 commit intoplasmodic:masterfrom
cottsay:patch-1
Closed
Only add -msse4.2 if it is supported by the compiler#29cottsay wants to merge 1 commit intoplasmodic:masterfrom cottsay:patch-1
cottsay wants to merge 1 commit intoplasmodic:masterfrom
cottsay:patch-1
Conversation
This is necessary to build on ARM platforms
vrabaud
added a commit
that referenced
this pull request
Jan 3, 2015
That would not work on ARM as explained in #29 plus it is useless now: opencv_candidate deals with it and it uses OpenCV flags
Member
|
Hi, though your pull request is totally valid (and thx for showing me that !), this SSE check is actually useless as that code has been moved to opencv_candidate (which actually does not need that flag anymore). I'll make a new release for you. Thx ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using CMake's
check_cxx_compiler_flag(), determine if the compiler supports-msse4.2and add it only if it does.The primary motivation is that the flag is not supported on ARM platforms for obvious reasons, and causes the build to fail. This is currently (01/02/2015) the only
Jadepackage not building on ARM in Fedora.The check does output the result to the console so it can be verified that it is working correctly. Look for
GCC_HAS_SSE.Example ARM build failure: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_armhfp/1/consoleFull
Example ARM build after patch: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_armhfp/3/consoleFull
Example x86 build after patch: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_x86_64/3/consoleFull
Thanks,
--scott