Skip to content

Only add -msse4.2 if it is supported by the compiler#29

Closed
cottsay wants to merge 1 commit intoplasmodic:masterfrom
cottsay:patch-1
Closed

Only add -msse4.2 if it is supported by the compiler#29
cottsay wants to merge 1 commit intoplasmodic:masterfrom
cottsay:patch-1

Conversation

@cottsay
Copy link
Contributor

@cottsay cottsay commented Jan 2, 2015

Using CMake's check_cxx_compiler_flag(), determine if the compiler supports -msse4.2 and add it only if it does.

The primary motivation is that the flag is not supported on ARM platforms for obvious reasons, and causes the build to fail. This is currently (01/02/2015) the only Jade package not building on ARM in Fedora.

The check does output the result to the console so it can be verified that it is working correctly. Look for GCC_HAS_SSE.

Example ARM build failure: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_armhfp/1/consoleFull
Example ARM build after patch: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_armhfp/3/consoleFull
Example x86 build after patch: http://csc.mcs.sdsmt.edu/jenkins/job/ros-jade-ecto-opencv_binaryrpm_21_x86_64/3/consoleFull

Thanks,

--scott

This is necessary to build on ARM platforms
vrabaud added a commit that referenced this pull request Jan 3, 2015
That would not work on ARM as explained in #29 plus it is useless
now: opencv_candidate deals with it and it uses OpenCV flags
@vrabaud
Copy link
Member

vrabaud commented Jan 3, 2015

Hi, though your pull request is totally valid (and thx for showing me that !), this SSE check is actually useless as that code has been moved to opencv_candidate (which actually does not need that flag anymore). I'll make a new release for you. Thx !

@vrabaud vrabaud closed this Jan 3, 2015
@cottsay cottsay deleted the patch-1 branch June 3, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants