Fix for pickling support (multiprocessing issue on Windows) #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if __name__ == '__main__': | ||
| freeze_support() | ||
| with Pool(processes=cpu_count()) as pool: | ||
| for res in pool.map(process_xref_file_worker, range(10)): |
Check notice
Code scanning / CodeQL
Unused global variable Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To resolve this issue, replace the unused variable res in the for loop with the conventional underscore (_). This makes it clear to readers and static analysis tools that the value produced by the loop is intentionally ignored. The change requires updating line 10 in the file test/issues/test-issue914.py, replacing for res in ... with for _ in .... No further code modifications are necessary, as the rest of the code is unaffected.
Suggested changeset
1
test/issues/test-issue914.py
| @@ -7,6 +7,6 @@ | ||
| if __name__ == '__main__': | ||
| freeze_support() | ||
| with Pool(processes=cpu_count()) as pool: | ||
| for res in pool.map(process_xref_file_worker, range(10)): | ||
| for _ in pool.map(process_xref_file_worker, range(10)): | ||
| pass | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
zyrxvo
added a commit
to zyrxvo/scalene
that referenced
this pull request
Nov 5, 2025
* Bumped version. * Fix for pickling support (multiprocessing issue on Windows) (plasma-umass#954) * Pickling support for multiprocessing, fixes 914. * Modified MWE from 914 to properly freeze state, per documentation. * Format code with black * Bumped CI to 3.14. (plasma-umass#955) * Document support for 3.14. * Force NumPy version 2 for Python 3.14. --------- Co-authored-by: Emery Berger <emery.berger@gmail.com> Co-authored-by: emeryberger <emeryberger@users.noreply.github.com>
zyrxvo
added a commit
to zyrxvo/scalene
that referenced
this pull request
Nov 14, 2025
* Bumped version. * Fix for pickling support (multiprocessing issue on Windows) (plasma-umass#954) * Pickling support for multiprocessing, fixes 914. * Modified MWE from 914 to properly freeze state, per documentation. * Format code with black * Bumped CI to 3.14. (plasma-umass#955) * Document support for 3.14. * Force NumPy version 2 for Python 3.14. * Move to macos-latest (per https://github.blog/changelog/2025-09-19-github-actions-macos-13-runner-image-is-closing-down/). * Updated dep for Python>=3.9 * Restore 3.8 support (plasma-umass#958) * Updated to see if 3.8 can still be supported. * One more update. * Format code with black --------- Co-authored-by: Emery Berger <emery.berger@gmail.com> Co-authored-by: emeryberger <emeryberger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #914.