Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single column properties or header lead to rendering error #355

Closed
chriskn opened this issue May 10, 2024 · 3 comments
Closed

Single column properties or header lead to rendering error #355

chriskn opened this issue May 10, 2024 · 3 comments
Milestone

Comments

@chriskn
Copy link

chriskn commented May 10, 2024

Hi C4-PlantUML Team,

I might recognize an issue with property rendering. Using single values for property headers (e.g SetPropertyHeader("Property")) or values (e.g AddProperty("Property")) lead to a rendering error. Using single column tables might sound odd, but would be handy to display lists.

Error:
grafik

Example for header

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Deployment.puml

' error
SetPropertyHeader("Property")
AddProperty("Prop2", "Value2")
Container(nodeAlias, "Label", "Optional Type", "Optional Description (with custom property header)") {

@enduml

Example for properties

@startuml
!include https://raw.githubusercontent.com/plantuml-stdlib/C4-PlantUML/master/C4_Deployment.puml

' error
AddProperty("Prop2")
Container(nodeAlias, "Label", "Optional Type", "Optional Description (with custom property header)") {

@enduml

versions tested: 1.2024.1, 1.2024.4

kirchsth added a commit to kirchsth/C4-PlantUML that referenced this issue May 10, 2024
@kirchsth
Copy link
Member

Hi @chriskn,

I created the MR #356 and updated my extended branch with the new implementation.
Does it match with your expectation?

Thank you
Helmut

kirchsth added a commit to kirchsth/C4-PlantUML that referenced this issue May 10, 2024
@kirchsth kirchsth added this to the v2.10.0 milestone May 10, 2024
@chriskn chriskn changed the title Single row properties or header lead to rendering error Single column properties or header lead to rendering error May 11, 2024
@chriskn
Copy link
Author

chriskn commented May 11, 2024

Awesome!

Thank you, Helmut

@chriskn chriskn closed this as completed May 11, 2024
@kirchsth
Copy link
Member

PS.: Hi @chriskn,

not direct related to your issue, but did you know that you can combine elements with Json too (details see discussion)?
Maybe it is useful for your structurizr-c4puml-extension
It has only one disadvantage that it can be only combined with elements (if you want to use it with Rel() then you would have to add a note to the Rel() and this note could again contains Json)

BR Helmut

kirchsth added a commit that referenced this issue May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants