Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tool configurations #291

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Clean up tool configurations #291

merged 1 commit into from
Mar 14, 2022

Conversation

plannigan
Copy link
Owner

@plannigan plannigan commented Mar 9, 2022

  • Change black's target python version
  • Switch black to extend-exclude. Most (all?) of the entries are excluded by black by default. it is better to only list the things that are specific to the project.
  • Change isort to use black profile. This will simplify the number of settings that need to be specified because isort comes with a profile that matches how black formats code.
  • Use testpaths in pytest instead the python_files setting that only matches files in the tests directory.

Closes #275

@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #291 (3bb2ecc) into main (a0d5cb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files           6        6           
  Lines         347      347           
  Branches       51       51           
=======================================
  Hits          336      336           
  Misses          9        9           
  Partials        2        2           

| tests/data
)/
'''
target-version = ["py37", "py38", "py39", "py310"]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should include all Python versions that you want your code to run under. In practice, though, 3.6 through 3.8 are currently the same as far as Black is concerned ...

(Source: psf/black#751)

@joaufi joaufi self-requested a review March 14, 2022 15:14
Copy link
Collaborator

@joaufi joaufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- should see a decent speedup by using testpaths instead of python_files as the test suite grows.

@plannigan plannigan merged commit 3218b07 into main Mar 14, 2022
@plannigan plannigan deleted the clean_up_tool_configs branch March 14, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up tool configurations
3 participants