Open
Description
openedon Oct 2, 2023
Groups are deprecated feature, but still available for use in proto2.
Following proto leads to uncompilable output:
syntax = "proto2";
message MyMessage {
repeated group Group = 1 {
optional int32 i32 = 1;
}
}
Generated message contains slice of struct generated for group:
Group []*MyMessage_Group `protobuf:"group,1,rep,name=Group,json=group" json:"group,omitempty"`
VtProto generates code as it's just a message, not a slice:
size, err := m.Group.MarshalToSizedBufferVT(dAtA[:i])
l = m.Group.SizeVT()
m.Group.UnmarshalVT(dAtA[groupStart:maybeGroupEnd])
Expected behaviour: to handle it as list of messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
No labels