-
Notifications
You must be signed in to change notification settings - Fork 88
deploy: Remove duplicate operator service account definition #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey! The main operator yaml file in the test is not changing in this PR despite the changes to the And then copy this file into |
Signed-off-by: f.medini <f.medini@nyris.io>
|
I'm not sure what you mean by Also the deployment's |
Signed-off-by: f.medini <f.medini@nyris.io>
|
I updated the commit to ensure only equivalent changes are made in |
|
I see backup related jobs are failing, and they're using the |
Signed-off-by: f.medini <f.medini@nyris.io>
|
Anything I need to do to get the |
|
Thanks, @mdnfiras ! The tests now pass, which is good. 🙂 Can you please explain in the PR description why the specific implementation/changes in the PR are the correct way to address the issue? |
This solve an issue described in vitessio/vitess/issues/19054 and solved in vitessio/vitess/pull/19053.
I'm reimplementing this here to sync things up and get a better signal as to whether or not there are any unexpected/unintended side effects.
cc @mattlord