Merged
Conversation
nickvanw
force-pushed
the
nick/vtctld-cli-base
branch
from
4195ce4 to
8172bd9
Compare
Add the lookup-vindex subcommand group with create, show, externalize, internalize, cancel, and complete operations. These allow managing Lookup Vindex operations on Vitess branches through the CLI. Signed-off-by: Nick Van Wiggeren <nick@planetscale.com>
nickvanw
force-pushed
the
nick/vtctld-cli-lookup-vindex
branch
from
2c021bf to
b581ce3
Compare
dgraham
approved these changes
Feb 24, 2026
Add tests for externalize/internalize/cancel/complete and verify optional bool flags are omitted unless explicitly set. Clarify --delete help text to reflect workflow deletion semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lookup-vindexsubcommand group underpscale branch vtctld*boolfields use thecmd.Flags().Changed()guard pattern so server defaults are respected when flags aren't explicitly setStacked on #1195.