Skip to content

Reorder list kwargs to maintain consistency between releases #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGES.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
2.12.0 (2024-12-06)
- Add parameters to the subscriptions list command: --created, --start-time,
2.12.0 (2024-12-09)
- Add parameters to the subscriptions list command: --source-type, --created, --start-time,
--end-time, --updated, --hosting, --name, --name-contains, and --sort-by.
- Add parameters to the orders list command: --source-type, --name,
--name-contains, --created-on, --last-modified, --hosting, and --sort-by.
- Remove the unused limit parameter of SubscriptionsClient.get_results_csv

2.11.0 (2024-10-21)

Expand Down
21 changes: 11 additions & 10 deletions planet/clients/orders.py
Original file line number Diff line number Diff line change
Expand Up @@ -462,16 +462,17 @@ async def wait(self,

return current_state

async def list_orders(self,
state: Optional[str] = None,
source_type: Optional[str] = None,
name: Optional[str] = None,
name__contains: Optional[str] = None,
created_on: Optional[str] = None,
last_modified: Optional[str] = None,
hosting: Optional[bool] = None,
sort_by: Optional[str] = None,
limit: int = 100) -> AsyncIterator[dict]:
async def list_orders(
self,
state: Optional[str] = None,
limit: int = 100,
source_type: Optional[str] = None,
name: Optional[str] = None,
name__contains: Optional[str] = None,
created_on: Optional[str] = None,
last_modified: Optional[str] = None,
hosting: Optional[bool] = None,
sort_by: Optional[str] = None) -> AsyncIterator[dict]:
"""Iterate over the list of stored orders.

By default, order descriptions are sorted by creation date with the last created
Expand Down
25 changes: 13 additions & 12 deletions planet/clients/subscriptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,19 @@ def __init__(self,
if self._base_url.endswith('/'):
self._base_url = self._base_url[:-1]

async def list_subscriptions(self,
created: Optional[str] = None,
end_time: Optional[str] = None,
hosting: Optional[bool] = None,
name__contains: Optional[str] = None,
name: Optional[str] = None,
source_type: Optional[str] = None,
start_time: Optional[str] = None,
status: Optional[Sequence[str]] = None,
sort_by: Optional[str] = None,
updated: Optional[str] = None,
limit: int = 100) -> AsyncIterator[dict]:
async def list_subscriptions(
self,
status: Optional[Sequence[str]] = None,
limit: int = 100,
created: Optional[str] = None,
end_time: Optional[str] = None,
hosting: Optional[bool] = None,
name__contains: Optional[str] = None,
name: Optional[str] = None,
source_type: Optional[str] = None,
start_time: Optional[str] = None,
sort_by: Optional[str] = None,
updated: Optional[str] = None) -> AsyncIterator[dict]:
"""Iterate over list of account subscriptions with optional filtering and sorting.

Note:
Expand Down
Loading