modernize with pyproject, use scm for version #1067
Conversation
ischneider
force-pushed
the
pyproject
branch
2 times, most recently
from
10fb1c8
to
439764c
Compare
|
The Python version in the contributing doc should be updated to one of the supported versions with this MR (it's currently set to 3.7): https://github.com/planetlabs/planet-client-python/blob/main/CONTRIBUTING.md?plain=1#L174-L195. |
| __version__ = '2.11.0dev' | ||
| from importlib.metadata import version | ||
|
|
||
| __version__ = version("planet") |
There was a problem hiding this comment.
Slick! I haven't seen this before. From the docs it looks like version() will pull the version number of the package as a string from the pypi distribution package? Does that mean we don't have to bump the version number manually anymore and this will just pull whatever version we tag?
There was a problem hiding this comment.
Yes, this makes releasing much simpler!
There was a problem hiding this comment.
LGTM! After this MR is merged I will follow up with an update to the release process that reflects the changes to version.py. Before you merge could you update the Python version here https://github.com/planetlabs/planet-client-python/blob/main/CONTRIBUTING.md?plain=1#L174-L195 ?
replace use of python 3.7 with more recent versions
|
Updated various references to 3.7 with recent versions... I stuck w/ 3.12 for the git actions as this is what ubuntu-latest provides? (don't think it matters which version, as long as it runs...) |
Related Issue(s):
N/A
Proposed Changes:
Modernize project metadata, use scm for versioning
Diff of User Interface
N/A
PR Checklist: