Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust how PV source types are documented. #1047

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

pl-gideon
Copy link
Member

Link to documentation and OpenAPI spec instead of maintaining separately.

Related Issue(s):

Closes #

Proposed Changes:

For inclusion in changelog (if applicable):

Client does not require a new release to support additional PV source types.

Not intended for changelog:

Diff of User Interface

Old behavior:

Client requires a new release to support additional PV source types.

New behavior:

Client does not require a new release to support additional PV source types.

  • Validate source types in CLI with API instead of click.Option.
  • Refer to Developer Center documentation in docstrings and CLI --help instead of maintaining separately

PR Checklist:

  • This PR is as small and focused as possible
  • If this PR includes proposed changes for inclusion in the changelog, the title of this PR summarizes those changes and is ready for inclusion in the Changelog.
  • I have updated docstrings for function changes and docs in the 'docs' folder for user interface / behavior changes
  • This PR does not break any examples or I have updated them

(Optional) @mentions for Notifications:

* Validate source types in CLI with API instead of `click.Option`.
* Refer to Developer Center documentation in docstrings and CLI `--help` instead of maintaining separately.
@pl-gideon pl-gideon force-pushed the adjust-pv-source-types-documentation branch from 1c1fc61 to 5c9a157 Compare June 18, 2024 20:41
@pl-gideon pl-gideon merged commit 2493a26 into main Jun 20, 2024
10 checks passed
@pl-gideon pl-gideon deleted the adjust-pv-source-types-documentation branch June 20, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants