Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the get_results_csv subscriptions operation does not throttle itself #1059

Open
ischneider opened this issue Sep 30, 2024 · 0 comments · May be fixed by #1060
Open

the get_results_csv subscriptions operation does not throttle itself #1059

ischneider opened this issue Sep 30, 2024 · 0 comments · May be fixed by #1060
Assignees
Labels
bug subscriptions api verified reported issue can be reproduced

Comments

@ischneider
Copy link
Member

Expected behavior

get_results_csv should use the client's session's stream function rather than the lower-level httpx client's stream

while the stream itself cannot be retried, this results in the initial request being throttled (and retried)

Actual behavior (describe the problem)

there is no throttling and basic unlimited usage will result in TooManyRequest errors

Related Issues

n/a

Workaround

manual throttling and/or retries

Minimum, Complete, Viable Code Sample

n/a

@ischneider ischneider added bug verified reported issue can be reproduced subscriptions api labels Sep 30, 2024
@ischneider ischneider self-assigned this Sep 30, 2024
@ischneider ischneider linked a pull request Sep 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug subscriptions api verified reported issue can be reproduced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant