Add support for uncordoning nodes #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 74.18% 76.67% +2.49%
==========================================
Files 7 7
Lines 488 553 +65
==========================================
+ Hits 362 424 +62
+ Misses 116 115 -1
- Partials 10 14 +4
Continue to review full report at Codecov.
|
jacobstr
approved these changes
Sep 11, 2020
| expected: &core.Node{ObjectMeta: meta.ObjectMeta{Name: nodeName}}, | ||
| }, | ||
| { | ||
| name: "UncordonUnschedulableNodeWithMutator", |
There was a problem hiding this comment.
I was looking for a test case where a node remains unschedulable even if draino has no reason to uncordon it.
There was a problem hiding this comment.
...And I found it here: https://github.com/planetlabs/draino/pull/84/files#diff-45cd5412f9ec9294054951666bce4620R159
|
Thanks for taking a look at this. Rebased and conflicts solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions in #27 (comment) it can be useful to draino to detect that a condition that triggered a node being cordoned is no longer present.
This PR introduces the ability for draino to track which conditions triggered the cordon+drain process in an annotation named
draino.planet.com/conditions.Whenever this annotation is present draino will check if the conditions are still present in the node, if they are not present anymore draino will try to uncordon the node and possibly skip draining the node if it wasn't scheduled yet.
I'm marking this as a draft because I'm still going to write a few unit tests, but the functionality is mostly ready and I've been able to test it on a real cluster.One question, would the maintainers like for me to put this feature behind a flag (eg:
--allow-uncordon)? I don't think it's dangerous to allow uncordoning but it can be unexpected for users upgrading draino.Fixes #27