Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail to start if node-label is provided twice with the same key - issue #107 #108

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

dbenque
Copy link
Contributor

@dbenque dbenque commented Dec 11, 2020

Fix #107
Draino will exit with error and not fail silently if the same key is provided twice in the node-label parameter that does a AND in case it is provided multiple times.

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #108 (f5f0f45) into master (e0d5277) will increase coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   75.21%   75.58%   +0.36%     
==========================================
  Files           7        7              
  Lines         464      471       +7     
==========================================
+ Hits          349      356       +7     
  Misses        101      101              
  Partials       14       14              
Impacted Files Coverage Δ
internal/kubernetes/nodefilters.go 92.30% <100.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0d5277...f5f0f45. Read the comment docs.

@jacobstr jacobstr merged commit 9d39b53 into planetlabs:master Dec 14, 2020
@dbenque dbenque deleted the david.benque/issue-107 branch January 7, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConvertLabelsToFilterExpr fails silently when multiple labels with same key
2 participants