Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1165: Parse more Open Graph metadata #1521

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

joshuatbrown
Copy link
Contributor

@joshuatbrown joshuatbrown commented Sep 18, 2024

Issues covered

#1165

Description

Parses more of the Open Graph metadata from the HTML, like the title, URLs, and type.

How to test

Run the unit tests

Notes

Skipping CHANGELOG since the previous entry covers it:

Added SwiftSoup to parse Open Graph metadata. [#1165]

Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One suggestion, feel free to ignore.

Nos/Models/OpenGraph/SoupOpenGraphParser.swift Outdated Show resolved Hide resolved
@joshuatbrown joshuatbrown added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 86791b5 Sep 19, 2024
4 checks passed
@joshuatbrown joshuatbrown deleted the open-graph-media-type branch September 19, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants